Hi, > Do they really? Couldn't one just include cdi-osdep.h in cdi.h or > cdi/misc.h? (Just asking) Yes, but this patch's intent was to remove that dependency (ie, no #include "cdi-osdep.h" in cdi.h). As Kevin pointed out, forward declaring struct cdi_driver is a better solution anyway. Cheers, Matt