[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cdi-devel] [PATCH] Remove dependency on cdi-osdep.h in cdi.h

On Thu, Dec 10, 2009 at 11:53:49AM +1000, Matthew Iselin wrote:
> Hi,
> This patch removes the dependency on cdi-osdep.h in cdi.h, in order to handle situations where cdi-osdep.h may need to define OS-specific functions and structs which need cdi.h (and other headers which might include cdi.h).

I'm hesitant to take this one. It means that driver need to include
cdi-osdep.h explicitly to get CDI_DRIVER, CDI_STANDALONE and so on.

Is there a real need for Pedigree to have this? If you just need to
reference struct cdi_driver you could still add a forward declaration
to cdi-osdep.h.