Re: [cdi-devel] [PATCH 5/5] usb-hid: Add driver

[Kevin Wolf <kevin@xxxxxxxxxx>]

On Tue, Dec 29, 2015 at 01:00:54AM +0100, Max Reitz wrote:
> Signed-off-by: Max Reitz <max@xxxxxxxxxx>
> ---
>  usb-hid/main.c    |  74 ++++++++++++++++++++++++++
>  usb-hid/usb-hid.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  usb-hid/usb-hid.h |  54 +++++++++++++++++++
>  3 files changed, 281 insertions(+)
>  create mode 100644 usb-hid/main.c
>  create mode 100644 usb-hid/usb-hid.c
>  create mode 100644 usb-hid/usb-hid.h

I guess I should send patches to merge that stub main.c of all drivers
into their real main file. Or do you think it's actually useful?

> diff --git a/usb-hid/usb-hid.h b/usb-hid/usb-hid.h
> new file mode 100644
> index 0000000..54c63a6
> --- /dev/null
> +++ b/usb-hid/usb-hid.h
> @@ -0,0 +1,54 @@
> +/******************************************************************************
> + * Copyright (c) 2015 Max Reitz                                               *
> + *                                                                            *
> + * Permission is hereby granted,  free of charge,  to any person  obtaining a *
> + * copy of this software and associated documentation files (the "Software"), *
> + * to deal in the Software without restriction,  including without limitation *
> + * the rights to use, copy,  modify, merge, publish,  distribute, sublicense, *
> + * and/or  sell copies of the  Software,  and to permit  persons to whom  the *
> + * Software is furnished to do so, subject to the following conditions:       *
> + *                                                                            *
> + * The above copyright notice and this permission notice shall be included in *
> + * all copies or substantial portions of the Software.                        *
> + *                                                                            *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR *
> + * IMPLIED,  INCLUDING BUT NOT LIMITED TO THE WARRANTIES  OF MERCHANTABILITY, *
> + * FITNESS  FOR A PARTICULAR  PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL *
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER *
> + * LIABILITY,  WHETHER IN AN ACTION OF CONTRACT,  TORT OR OTHERWISE,  ARISING *
> + * FROM,  OUT OF  OR IN CONNECTION  WITH  THE SOFTWARE  OR THE  USE OR  OTHER *
> + * DEALINGS IN THE SOFTWARE.                                                  *
> + ******************************************************************************/
> +
> +#ifndef USB_HID_H
> +#define USB_HID_H
> +
> +#include <cdi.h>
> +#include <cdi/scsi.h>

Are you sure?

Kevin