Re: [cdi-devel] [PATCH v2] Direct access to PCI configuration space

[Kevin Wolf <kevin@xxxxxxxxxx>]

On Sun, Dec 20, 2009 at 01:27:58PM +0100, Kevin Wolf wrote:
> On Sun, Dec 20, 2009 at 11:56:44AM +0100, max@xxxxxxxxxx wrote:
> > From: Max Reitz <max@xxxxxxxxxx>
> > 
> > + Some drivers need direct access to the PCI configuration space
> > 
> > Signed-off-by: Max Reitz <max@xxxxxxxxxx>
> > ---
> >  include/cdi/pci.h |  114 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 114 insertions(+), 0 deletions(-)
> 
> In some of the doxygen comment the \endif is missing. Also, I'd like to
> see the functions named readb/writeb instead of outb/inb (the latter is
> almost uniquely used for the x86 IO ports which is completely unrelated)
> 
> No need to resend though. I'm going to make these changes to the patch
> myself and apply it if there are no objections.

I haven't heard back from anyone, so I applied this one now.