[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cdi-devel] [PATCH] CDI.usb, mempool

On Fri, Dec 11, 2009 at 07:24:42PM +1000, Matthew Iselin wrote:
> On Thu, Dec 10, 2009 at 5:50 AM,  <max@xxxxxxxxxx> wrote:
> > From: Max Reitz <max@xxxxxxxxxx>
> >
> > * Split the CDI.usb function "cdi_usb_driver_init_and_register"
> >  into an init and a register function, because a driver using the
> >  new driver registering method (via CDI_DRIVER macros) may not
> >  register itself
> > + mempool as CDI header (has been used in the old USB driver)
> >
> > Signed-off-by: Max Reitz <max@xxxxxxxxxx>
> Minor nitpick: at some point you may want to document the mempool header.
> Acked-by: Matthew Iselin <matthew@xxxxxxxxxxxxxx>

This is actually not a minor nitpick, but a good reason to reject a
patch right away. I'll consider the patch as an exception only because
this interface is going to be changed anyway when we introduce cdi_mem_area
as discussed in the audio/IDC thread.