Re: [tyndur-devel] [PATCH 1/6] libc: MIN/MAX-Makros fuer stdint.h

[Antoine Kaufmann <toni@xxxxxxxxxx>]

On Sun, Aug 16 22:22, Kevin Wolf wrote:
> + libc: MIN/MAX-Makros fuer alle moeglichen Integer-Datentypen, die es
>   in stdint.h geben sollte
> + libc: (U)INTxx_C-Markos fuer Integerkonstanten
> 
> Signed-off-by: Kevin Wolf <kevin@xxxxxxxxxx>
> ---
>  src/include/arch/i386/stdint.h |   87 ++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 87 insertions(+), 0 deletions(-)
> 
> diff --git a/src/include/arch/i386/stdint.h b/src/include/arch/i386/stdint.h
> index 4f94b39..9262887 100644
> --- a/src/include/arch/i386/stdint.h
> +++ b/src/include/arch/i386/stdint.h
> @@ -29,6 +29,24 @@
>  #ifndef _STDINT_H_
>  #define _STDINT_H_
>  
> +#include <limits.h>

Hm bist du sicher, dass stdint.h die limits.h reinziehen darf? Ich habe
dazu weder im Standard noch in der Manpage was gefunden...

> +
> +#define INT8_MIN -128
> +#define INT8_MAX 127
> +#define UINT8_MAX 255
> +
> +#define INT16_MIN -32768
> +#define INT16_MAX 32767
> +#define UINT16_MAX 65535
> +
> +#define INT32_MIN ((int32_t) -0x80000000)
> +#define INT32_MAX 0x7FFFFFFF
> +#define UINT32_MAX ((uint32_t) -1)
> +
> +#define INT64_MIN ((int64_t) -0x8000000000000000LL)
> +#define INT64_MAX 0x7FFFFFFFFFFFFFFFLL
> +#define UINT64_MAX ((uint64_t) -1ULL)
> +
>  typedef signed char int8_t;
>  typedef signed short int16_t;
>  typedef signed int int32_t;
> @@ -40,6 +58,22 @@ typedef unsigned int uint32_t;
>  typedef unsigned long long uint64_t;
>  
>  
> +#define INT_LEAST8_MIN INT8_MIN
> +#define INT_LEAST8_MAX INT8_MAX
> +#define UINT_LEAST8_MAX UINT8_MAX
> +
> +#define INT_LEAST16_MIN INT32_MIN
> +#define INT_LEAST16_MAX INT32_MAX
> +#define UINT_LEAST16_MAX UINT32_MAX
> +
> +#define INT_LEAST32_MIN INT32_MIN
> +#define INT_LEAST32_MAX INT32_MAX
> +#define UINT_LEAST32_MAX UINT32_MAX
> +
> +#define INT_LEAST64_MIN INT64_MIN
> +#define INT_LEAST64_MAX INT64_MAX
> +#define UINT_LEAST64_MAX UINT64_MAX
> +
>  typedef int8_t int_least8_t;
>  typedef int32_t int_least16_t;
>  typedef int32_t int_least32_t;
> @@ -51,6 +85,22 @@ typedef uint32_t uint_least32_t;
>  typedef uint64_t uint_least64_t;
>  
>  
> +#define INT_FAST8_MIN INT8_MIN
> +#define INT_FAST8_MAX INT8_MAX
> +#define UINT_FAST8_MAX UINT8_MAX
> +
> +#define INT_FAST16_MIN INT32_MIN
> +#define INT_FAST16_MAX INT32_MAX
> +#define UINT_FAST16_MAX UINT32_MAX
> +
> +#define INT_FAST32_MIN INT32_MIN
> +#define INT_FAST32_MAX INT32_MAX
> +#define UINT_FAST32_MAX UINT32_MAX
> +
> +#define INT_FAST64_MIN INT64_MIN
> +#define INT_FAST64_MAX INT64_MAX
> +#define UINT_FAST64_MAX UINT64_MAX
> +
>  typedef int8_t int_fast8_t;
>  typedef int32_t int_fast16_t;
>  typedef int32_t int_fast32_t;
> @@ -62,10 +112,47 @@ typedef uint32_t uint_fast32_t;
>  typedef uint64_t uint_fast64_t;
>  
>  
> +#define INTPTR_MIN INT32_MIN
> +#define INTPTR_MAX INT32_MAX
> +#define UINTPTR_MAX UINT32_MAX
> +
> +#define INTMAX_MIN INT64_MIN
> +#define INTMAX_MAX INT64_MAX
> +#define UINTMAX_MAX UINT64_MAX
> +
>  typedef unsigned int uintptr_t;
>  typedef long int intptr_t;
>  
>  typedef int64_t intmax_t;
>  typedef uint64_t uintmax_t;
>  
> +/* MIN/MAX fuer Typen aus anderen Headern */
> +
> +#define PTRDIFF_MIN INT_MIN
> +#define PTRDIFF_MAX INT_MAX
> +
> +#define WCHAR_MIN INT32_MIN
> +#define WCHAR_MAX INT32_MAX
> +
> +#define WINT_MIN WCHAR_MIN
> +#define WINT_MAX WCHAR_MAX
> +
> +#define SIG_ATOMIC_MIN 0
> +#define SIG_ATOMIC_MAX UINT32_MAX
> +
> +#define SIZE_MAX ((__SIZE_TYPE__) -1)
> +
> +
> +/* Makros fuer Integerkonstanten */
> +
> +#define INT8_C(x) ((int_least8_t) x)
> +#define INT16_C(x) ((int_least16_t) x)
> +#define INT32_C(x) ((int_least32_t) x)
> +#define INT64_C(x) ((int_least64_t) x ## LL)
> +
> +#define UINT8_C(x) ((uint_least8_t) x)
> +#define UINT16_C(x) ((uint_least16_t) x)
> +#define UINT32_C(x) ((uint_least32_t) x)
> +#define UINT64_C(x) ((uint_least64_t) x ## ULL)
> +
>  #endif
> 

Ansonsten sieht das gut aus. Wenn das gefixt ist:

Acked-by: Antoine Kaufmann <toni@xxxxxxxxxx>
-- 
Antoine Kaufmann
<toni@xxxxxxxxxxxxxxxx>

Attachment: pgpTkYvBMAuS5.pgp
Description: PGP signature