Re: [tyndur-devel] [PATCH] cdi/core: subclass und interface-Feld fuer pci_device-Struktur

[Kevin Wolf <mail@xxxxxxxxxxxxx>]

Am Freitag, 30. Januar 2009 03:11 schrieb Antoine Kaufmann:
> * cdi/core: Einzelne Member in der pci_device-Struktur für die
>             Subclass-ID und die Interface-ID.

Aus meiner Sicht in Ordnung. Aber vielleicht sollten Janosch und Mathias noch 
was dazu sagen.

> ---
>  src/modules/cdi/include/cdi/pci.h |    6 +++++-
>  src/modules/cdi/lib/pci.c         |    2 ++
>  2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/src/modules/cdi/include/cdi/pci.h
> b/src/modules/cdi/include/cdi/pci.h index af1a79c..8a9cc18 100644
> --- a/src/modules/cdi/include/cdi/pci.h
> +++ b/src/modules/cdi/include/cdi/pci.h
> @@ -23,7 +23,11 @@ struct cdi_pci_device {
>
>      uint16_t    vendor_id;
>      uint16_t    device_id;
> -    uint16_t    class_id;
> +
> +    uint8_t     class_id;
> +    uint8_t     subclass_id;
> +    uint8_t     interface_id;
> +
>      uint8_t     rev_id;
>
>      uint8_t     irq;
> diff --git a/src/modules/cdi/lib/pci.c b/src/modules/cdi/lib/pci.c
> index 90df6d0..e14f48a 100644
> --- a/src/modules/cdi/lib/pci.c
> +++ b/src/modules/cdi/lib/pci.c
> @@ -47,6 +47,8 @@ static struct cdi_pci_device* read_pci_device(char*
> filename) cdi_device->vendor_id    = device.vendor_id;
>      cdi_device->device_id    = device.device_id;
>      cdi_device->class_id     = device.class_id;
> +    cdi_device->subclass_id  = device.subclass_id;
> +    cdi_device->interface_id = device.interface_id;
>      cdi_device->rev_id       = device.rev_id;
>      cdi_device->irq          = device.irq;
>      cdi_device->resources    = cdi_list_create();